KEMBAR78
chore: update to electron 17 by deepak1556 · Pull Request #143223 · microsoft/vscode · GitHub
Skip to content

chore: update to electron 17 #143223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 10, 2022
Merged

chore: update to electron 17 #143223

merged 7 commits into from
Mar 10, 2022

Conversation

@deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Feb 16, 2022 •
edited
Loading

  • Create nightly exploration builds

Fixes #143353
Fixes #138721
Fixes #136787
Fixes #136260
Fixes #133820
Fixes #132086
Fixes #131714
Fixes #120431
Fixes #93615
Fixes #84453
Fixes #50386

@deepak1556 deepak1556 self-assigned this Feb 16, 2022
@deepak1556 deepak1556 added this to the March 2022 milestone Feb 16, 2022
@deepak1556 deepak1556 changed the title chore: bump electron@17.0.0 chore: update to electron 17 Feb 16, 2022
@deepak1556 deepak1556 force-pushed the electron-17.x.y branch 3 times, most recently from ef2d478 to 0f4d378 Compare February 22, 2022 04:01
@deepak1556 deepak1556 mentioned this pull request Feb 22, 2022
Closed
3 tasks
@microsoft microsoft deleted a comment Feb 23, 2022
@microsoft microsoft deleted a comment Feb 23, 2022
@microsoft microsoft deleted a comment Feb 23, 2022
@deepak1556 deepak1556 force-pushed the electron-17.x.y branch 3 times, most recently from d6ecda7 to 0058a30 Compare March 2, 2022 05:52
@Maskedman99 Maskedman99 mentioned this pull request Mar 6, 2022
Closed
@deepak1556 deepak1556 force-pushed the electron-17.x.y branch 3 times, most recently from 2f8deef to 17ae8c0 Compare March 9, 2022 10:40
@deepak1556 deepak1556 marked this pull request as ready for review March 9, 2022 11:32
@deepak1556 deepak1556 requested a review from bpasero March 10, 2022 08:47
bpasero
bpasero approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a weird merge conflict showing up but not in the overall result, can you double check:

image

@deepak1556 deepak1556 merged commit 32d40cf into main Mar 10, 2022
@deepak1556 deepak1556 deleted the electron-17.x.y branch March 10, 2022 15:51
@alexdima alexdima mentioned this pull request Mar 23, 2022
Closed
@joshsleeper joshsleeper mentioned this pull request Mar 25, 2022
Closed
87 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@deepak1556 deepak1556

Labels

None yet

Projects

None yet

Milestone

March 2022

Development

Successfully merging this pull request may close these issues.

Frequent Crash - Reason: 'crashed', Code: '-2147483645' Electron: Enable renderer process reuse Open File explorer search doesn't include files in subdirectories Native Windows title bar does not respect dark mode setting I set Dolphin as default file manager, but VSCode opens Nautilus instead of Dolphin
Workbench takes significantly longer than usual to become ready in Insiders Enlarging by dragging: Background not in accordance to OS theme After upgrade to MacOS Monterey, vscode unusable, extremely slow rendering Happened Again - Requests to servers using letsencrypt's new root certificate fail verifiction Crash on shutdown in v8impl::(anonymous namespace)::RefBase::Finalize

2 participants

@deepak1556 @bpasero