Implement language detection for notebook cells #147537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!documentTextSample) { return; } | ||
|
|
||
| const neuralResolver = async () => { | ||
| if (supportedLangs?.length) { return undefined; /* neural resolver doesnt support language tuning */ } |
There was a problem hiding this comment.
Could you just check if the language in the next line is a supportedLang before pushing to languages & confidence?
There was a problem hiding this comment.
Makes sense 👍 do the confidences need to be scaled differently?
There was a problem hiding this comment.
Actually sorry, line 52 ... we only return 1 language.... Can you just return the first language that's in supportedLang? The languages are already sorted by confidence by the detectLanguagesImpl.
Clean up mapping of language id's in neural model Add config to opt out of language detection hints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #147184