KEMBAR78
Add `onView:timeline` activation. by lramos15 · Pull Request #148052 · microsoft/vscode · GitHub
Skip to content

Conversation

@lramos15
Copy link
Member

This PR fixes #94151

Adds an activation event which activates extensions with onView:timeline when the timeline view is visible. I do not await this call because there's not much we can do once it's visible but when the timeline is refreshed the new providers should be included.

@lramos15 lramos15 requested a review from JacksonKearl April 25, 2022 15:03
@lramos15 lramos15 self-assigned this Apr 25, 2022
Copy link
Contributor

@JacksonKearl JacksonKearl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should incorporate this into the JSON schema as well

@JacksonKearl
Copy link
Contributor

Looks like we already have onView declared in the schema, I think thats good enough. When this goes stable the docs should mention it somewhere.

@lramos15 lramos15 enabled auto-merge (squash) May 6, 2022 18:03
@lramos15 lramos15 merged commit df5abb3 into main May 6, 2022
@lramos15 lramos15 deleted the lramos15/timelineContrib branch May 6, 2022 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contribution point for timeline provider

3 participants