add basic contextual commands #160952
Merged
add basic contextual commands #160952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
meganrogge
commented
Sep 15, 2022
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Sep 15, 2022
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Sep 15, 2022
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Sep 15, 2022
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
Tyriar
reviewed
Sep 15, 2022
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Sep 16, 2022
Tyriar
previously requested changes
Sep 20, 2022
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalBaseContextualActions.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalBaseContextualActions.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/contextualActionAddon.ts
Outdated
Show resolved
Hide resolved
…apability.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
…apability.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
|
Just need to test on windows |
|
couldn't test using server launcher on windows because the command doesn't finish when the port is already in use (perhaps it should, maybe a bug)?
since I couldn't get xterm.js to build, @Tyriar can you pls try this on windows to make sure it works? |
Tyriar
approved these changes
Sep 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #151937