KEMBAR78
Remove notebook controller kind API proposal by mjbvz · Pull Request #175962 · microsoft/vscode · GitHub
Skip to content

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Mar 2, 2023

Fixes #168535

@mjbvz mjbvz requested review from DonJayamanne and rebornix March 2, 2023 19:54
@mjbvz mjbvz self-assigned this Mar 2, 2023
@rebornix
Copy link
Member

rebornix commented Mar 3, 2023

Thanks @mjbvz, we also need to remove notebookControllerKind from the Jupyter extension, not sure if the Jupyter extension needs to be updated first.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 6, 2023

I reviewed the jupyter code. Looks like there are two places where we use kind:

I think both should still work after this PR

@DonJayamanne Can you please take a look and confirm that we are good to remove the kind property?

@mjbvz mjbvz marked this pull request as ready for review March 9, 2023 16:51
@vscodenpa vscodenpa added this to the March 2023 milestone Mar 9, 2023
@DonJayamanne
Copy link
Contributor

Lets merge this PR once we have removed this in Jupyter extension microsoft/vscode-jupyter#13068

DonJayamanne
DonJayamanne previously approved these changes Mar 15, 2023
@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 15, 2023

Should be good to merge now that we've removed the flat kernel picker

@mjbvz mjbvz merged commit 3e5253b into microsoft:main Mar 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalize or remove the notebookControllerKind API Proposal

4 participants