KEMBAR78
Notebooks respect `files.xyz` settings by Yoyokrazy · Pull Request #192941 · microsoft/vscode · GitHub
Skip to content

Notebooks respect files.xyz settings #192941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 18, 2023
Merged

Notebooks respect files.xyz settings #192941

merged 6 commits into from
Sep 18, 2023

Conversation

@Yoyokrazy
Copy link
Collaborator

@Yoyokrazy Yoyokrazy commented Sep 12, 2023 •
edited
Loading

Fixes: #181905

Notebooks now respect the settings:

  • files.trimTrailingWhitespace
  • files.trimFinalNewlines

@Yoyokrazy Yoyokrazy self-assigned this Sep 12, 2023
@Yoyokrazy Yoyokrazy requested a review from rebornix September 12, 2023 23:04
@vscodenpa vscodenpa added this to the September 2023 milestone Sep 12, 2023
@Yoyokrazy
Copy link
Collaborator Author

Also support:

  • files.insertFinalNewLine

rebornix
rebornix requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the right direction 👍, left some comments on how we can perform more efficiently.

@Yoyokrazy Yoyokrazy requested a review from rebornix September 14, 2023 14:04
rebornix
rebornix requested changes Sep 15, 2023
View reviewed changes
@Yoyokrazy Yoyokrazy enabled auto-merge (squash) September 18, 2023 17:32
rebornix
rebornix approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thank you!

@Yoyokrazy Yoyokrazy merged commit 5be77a3 into main Sep 18, 2023
@Yoyokrazy Yoyokrazy deleted the milively/nb-trim branch September 18, 2023 17:42
@chandra1109
Copy link

#193524
Review

chandra1109
chandra1109 reviewed Sep 20, 2023
View reviewed changes
Copy link

@chandra1109 chandra1109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review pending..

@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rebornix rebornix rebornix approved these changes

+1 more reviewer

@chandra1109 chandra1109 chandra1109 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Yoyokrazy Yoyokrazy

Labels

None yet

Projects

None yet

Milestone

September 2023

Development

Successfully merging this pull request may close these issues.

Bug: Jupyter Notebook trim whitespaces not working in code cells

4 participants

@Yoyokrazy @chandra1109 @rebornix @vscodenpa