Terminal ligatures take 4 #232829
Merged
Terminal ligatures take 4 #232829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why this is happening:
The typescript build succeeds. |
|
|
|
Product build needs to wait a while as xterm.js was only just published |
|
Product build worked on macOS 🎉 There's one pretty obvious issue where the background will often be wrong when typed out: 
I suspect it's the cell having the cursor background and then not being re-rendered when that cell is marked to skip rendering due to being a ligature part. |
|
Tracked in #233005 |
lramos15
approved these changes
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34103