fix: account for page zoom factor in getBoundingClientRect #234970
Conversation
deepak1556
force-pushed
the
robo/enable_standard_browser_zoom
branch
2 times, most recently
from
6147fed to
b52ebaf
Compare
|
Also looping in @benibenj, there is no urgency on this PR we can adopt it for January milestone. Looking at https://chromestatus.com/feature/5198254868529152 the standardization has only completed in Chromium since 128, firefox and safari have open bugs with positive signals. So we will need to feature check and keep the workaround for those cases. I will update the PR. |
|
And based on the spec PR we also need to cover |
|
|
||
| .monaco-workbench .part.titlebar > .titlebar-container.counter-zoom .menubar .menubar-menu-button > .menubar-menu-items-holder.monaco-menu-container, | ||
| .monaco-workbench .part.titlebar > .titlebar-container.counter-zoom .monaco-toolbar .dropdown-action-container { | ||
| .monaco-workbench .part.titlebar > .titlebar-container.counter-zoom .menubar .menubar-menu-button > .menubar-menu-items-holder.monaco-menu-container { |
There was a problem hiding this comment.
What is the reason for removing this? This was added to fix the zooming for the dropdown action to the right of the command center. Without this, the zooming is wrong for that action. This line counter zooms the position because the title bar does not support negative zoom values (due to WCO).
Ref: #231825
|
I've tested the changes, all is good except for the dropdown to the right of the command centre |
deepak1556
force-pushed
the
robo/enable_standard_browser_zoom
branch
from
b52ebaf to
21c615e
Compare
6 participants
Fixes #233692