Support nb cell Inline Values after cell execution #237995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoyokrazy
changed the title
rebornix
requested changes
Jan 16, 2025
src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts
Outdated
Show resolved
Hide resolved
| /** Cell execution inline vars */ | ||
| .nb-inline-value { | ||
| background-color: var(--vscode-editorInlayHint-background); | ||
| color: var(--vscode-editorInlayHint-foreground) !important; |
There was a problem hiding this comment.
we should figure out why the decoration we add gets tokenization colors to avoid !important if possible.
There was a problem hiding this comment.
will bring in a second PR, didn't find it at a first glance but will take another look. issue tracking here: #238091
src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts
Outdated
Show resolved
Hide resolved
rebornix
approved these changes
Jan 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #237263
Adds support for inline vars after cell execution in notebooks. Extensions can use the
InlineValuesProviderclass to contribute providers that will give more intelligent results.