Add window.menuStyle
#249339
Merged
Add window.menuStyle
#249339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
approved these changes
May 20, 2025
tarik02
reviewed
Jun 3, 2025
Comment on lines
+150
to
+153
| // Do not support native menu with custom title bar | ||
| if (!isMacintosh && !nativeTitle) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
let me ask, why? many linux desktop environments support global menu for example which will work with custom title bar
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced the setting
window.menuStylewhich supports 3 valuesnative,custom&inheritWindows & Linux: (Requires full restart to apply)
native: use native application menu and native context menucustom: use custom menu in the custom title bar and custom contxt menuinherit: use the same menu and context menu style as the titlebar (DEFAULT)MacOS:
native: use native context menu (DEFAULT)custom: use custom contxt menuinherit: use the same context menu style as the titlebarcloses #229053