feat: offer to move into Applications folder on macOS #249345
Conversation
I lean towards NO. And then we can add a setting if users complain. |
src/vs/code/electron-main/app.ts
Outdated
|
|
||
| if (response === 0) { | ||
| try { | ||
| const result = app.moveToApplicationsFolder({ |
There was a problem hiding this comment.
Its unclear to me what moveToApplicationsFolder does under the hood? Will it trigger our shutdown handlers, for example configure files.hotExit to off, have a dirty file and trigger the move, would it still confirm shutdown and allow to veto, given there is a dirty file not saved on shutdown.
There was a problem hiding this comment.
underneath the equivalent of app.quit is called from the runtime to exit the application which should invoke all shutdown related handlers for graceful exit, I haven't tested the above flow, will confirm.
src/vs/code/electron-main/app.ts
Outdated
| localize({ key: 'move', comment: ['&& denotes a mnemonic'] }, "&&Move to Applications"), | ||
| localize({ key: 'doNotMove', comment: ['&& denotes a mnemonic'] }, "&&Do not Move") | ||
| ], | ||
| message: localize('moveToApplicationsFolderWarning', "{0} works best when run from the Applications folder", this.productService.nameLong), |
There was a problem hiding this comment.
Perhaps it'd be nice to say something about the reason, e.g. "Auto-updating {0} works best..." or "{0} will not be able to auto-update unless you move it to the Applications folder"
deepak1556
force-pushed
the
robo/mv_to_applications_folder
branch
from
7df3620 to
eceb76f
Compare
deepak1556
force-pushed
the
robo/mv_to_applications_folder
branch
from
eceb76f to
4a00af9
Compare
4 participants
Fixes #213909
Detect when application on macOS is installed outside the Applications folder and offer choice to move. The detection will bail early under the following cases,
There are 3 cases this path should cover,
In this case, once user confirms the choice to move
app.moveToApplicationsFolderwill quit the current instance (which follows app.quit path in the runtime so all shutdown veto paths will be respected), copy the app to destination, trash the source app, wait for the application to exit and relaunch from the destinationconflictType === existsIn this case, once user confirms the choice to move
app.moveToApplicationsFolderdelete the version under Applications folder and follow the same order of steps as 1)conflictType === existsAndRunningIn this case, due to our singleton logic any new instance sharing the same user-data-dir will merge to the running instance and hence no action is needed. When using different user-data-dir the launch would happen from cli in which case the detection will bail early as mentioned before.
Question: