add onTerminal activation event
#254444
Merged
add onTerminal activation event
#254444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Jul 7, 2025
src/vs/workbench/services/extensions/common/extensionsRegistry.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Tyriar
previously approved these changes
Jul 7, 2025
Tyriar
previously requested changes
Jul 8, 2025
meganrogge
commented
Jul 8, 2025
mjbvz
approved these changes
Jul 8, 2025
Tyriar
reviewed
Jul 9, 2025
Comment on lines
+1027
to
+1031
| this._register(instance.onDidChangeShellType(() => this._extensionService.activateByEvent(`onTerminal:${instance.shellType}`))); | ||
| if (instance.shellType) { | ||
| this._extensionService.activateByEvent(`onTerminal:${instance.shellType}`); | ||
| } | ||
| return instance; |
There was a problem hiding this comment.
You can't register instance listeners against terminalservice like this as the references will remain when the terminal instance is disposed, potentially holding onto the TerminalInstance reference. You should do this in _initInstanceListeners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #252413