Use CIMD if supported #271403
Merged
Use CIMD if supported #271403
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Authorization Server we are auth'ing against supports the Client ID Metadata auth flow, we use the client id metadata url from product.json as the client id in auth flows. Fixes #270811
There was a problem hiding this comment.
Pull Request Overview
This PR implements Client ID Metadata Document (CIMD) support for OAuth authentication flows. When an authorization server supports CIMD, the authentication system will use the client ID metadata URL from product.json as the client ID.
Key changes:
- Added support for checking CIMD capability in authorization server metadata
- Modified authentication logic to use product.json's authClientIdMetadataUrl when CIMD is supported
- Extended the OAuth interface to include the CIMD support flag
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/api/browser/mainThreadAuthentication.ts | Added IProductService injection and logic to use CIMD URL when supported |
| src/vs/base/common/product.ts | Added optional authClientIdMetadataUrl property to product configuration |
| src/vs/base/common/oauth.ts | Added client_id_metadata_document_supported flag to OAuth server metadata interface |
| package.json | Updated distro hash |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dmitrivMS
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Authorization Server we are auth'ing against supports the Client ID Metadata auth flow, we use the client id metadata url from product.json as the client id in auth flows.
Fixes #270811