Add shell specific instructions #272153
Merged
Add shell specific instructions #272153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds shell-specific dynamic model descriptions for the Run in Terminal tool and refactors terminal profile resolution into a dedicated helper.
- Introduces TerminalProfileFetcher and removes inline profile logic from RunInTerminalTool.
- Replaces static RunInTerminalToolData with async factory createRunInTerminalToolData that tailors modelDescription per detected shell.
- Adds shell detection helpers (zsh, fish, Windows PowerShell) and updates tests to use the new profileFetcher API.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| runInTerminalTool.test.ts | Updates tests to use profileFetcher and adds coverage for custom profile and fallback behavior. |
| runInTerminalTool.ts | Refactors tool data creation, adds dynamic shell-specific descriptions, introduces TerminalProfileFetcher, removes embedded profile methods. |
| terminal.chatAgentTools.contribution.ts | Changes registration to asynchronously create shell-aware tool data before registering. |
| runInTerminalHelpers.ts | Adds helper functions for zsh, fish, and Windows PowerShell detection. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts
Show resolved
Hide resolved
bpasero
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262386