tools: add postapproval step for tool calls #272628
Merged
+1,055
−456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a post-execution approval step for tool calls, allowing users to review and approve tool results before they are sent to the language model. This is particularly useful for tools marked with openWorldHint that may return sensitive or extensive data.
Key Changes:
- Added
confirmResultsflag toIToolConfirmationMessagesfor post-execution confirmation - Introduced new state
WaitingForPostApprovalin tool invocation lifecycle - Created separate storage for pre-execution and post-execution auto-confirmation settings
- Implemented UI for reviewing tool output before sending to the model
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mcpLanguageModelToolContribution.ts | Updated MCP tool confirmation logic to use separate pre/post confirmation flags based on tool annotations |
| languageModelToolsService.ts | Made confirmation messages optional and added confirmResults flag for post-execution approval |
| chatService.ts | Added WaitingForPostApproval state and helper functions for post-execution confirmation workflow |
| chatProgressTypes/chatToolInvocation.ts | Refactored completion logic to handle post-approval state and serialize skipped results |
| languageModelToolsService.ts (browser) | Implemented post-execution confirmation flow with separate storage and auto-confirmation handling |
| chatToolPostExecuteConfirmationPart.ts | New UI component for displaying and approving tool results before sending to model |
| abstractToolConfirmationSubPart.ts | New base class abstracting common confirmation widget functionality |
| chatToolConfirmationSubPart.ts | Refactored to use base class and support conditional result review |
| chatToolOutputContentSubPart.ts | Extracted reusable component for rendering tool output with code blocks and resources |
| chatToolInputOutputContentPart.ts | Refactored to use the extracted output subpart component |
| mockLanguageModelToolsService.ts | Added mock implementation for new post-execution confirmation methods |
| languageModelToolsService.test.ts | Removed tests for deprecated auto-confirmation methods |
Comment on lines
+81
to
+83
| { label: localize('allowSession', 'Allow Without Review in this Session'), data: ConfirmationOutcome.AllowSession, tooltip: localize('allowSessionTooltip', 'Allow results from this tool to be sent without confirmation in this session.') }, | ||
| { label: localize('allowWorkspace', 'Allow Without Review in this Workspace'), data: ConfirmationOutcome.AllowWorkspace, tooltip: localize('allowWorkspaceTooltip', 'Allow results from this tool to be sent without confirmation in this workspace.') }, | ||
| { label: localize('allowGlobally', 'Always Allow Without Review'), data: ConfirmationOutcome.AllowGlobally, tooltip: localize('allowGloballyTooltip', 'Always allow results from this tool to be sent without confirmation.') }, |
There was a problem hiding this comment.
These action definitions are duplicated from chatToolConfirmationSubPart.ts (lines 89-91). Consider extracting these common action definitions into a shared constant or helper function to avoid duplication and ensure consistency.
Copilot uses AI. Check for mistakes.
connor4312
commented
Oct 22, 2025
| @@ -0,0 +1,267 @@ | |||
| /*--------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
This file is a mostly literal move from chatToolInputOutputContentPart.ts, doesn't need granular review
dbaeumer
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #270618