KEMBAR78
Use ASAR by alexdima · Pull Request #41353 · microsoft/vscode · GitHub
Skip to content

Use ASAR #41353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 29, 2018
Merged

Use ASAR #41353

merged 9 commits into from
Jan 29, 2018

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Jan 9, 2018 •
edited
Loading

Fixes #41350.

This change currently makes it that a node_modules.asar is picked up if present.

To run with asar, one must take a built version of vscode from this branch and execute:

asar pack node_modules node_modules.asar --unpack {*.node,*.exe}

Then, the node_modules folder can be deleted.

Observed time improvements (average of 5 runs, excluding first start):

Surface Book with Windows 10

TIME BEFORE AFTER DELTA
[main, renderer] start => extensions ready 1852.2 1766.4 85.8 ms (4.63%)
[main, renderer] start => workbench ready 1707.6 1652.4 55.2 ms (3.23%)

Lenovo W530 with Ubuntu 16.04 TLS

TIME BEFORE AFTER DELTA
[main, renderer] start => extensions ready 1580.4 1555.0 25.40 ms (1.61%)
[main, renderer] start => workbench ready 1313.0 1299.4 13.60 ms (1.04%)

File count reduction:

OS BEFORE AFTER DELTA
Windows 5,817 4,336 1,481 (-25.45%)
Linux 6,341 4,289 2,052 (-32.36%)

TODO:

  • searching is broken due to rg path being node_modules.asar.unpacked and not node_modules.asar.
  • incorporate the asar creation into the packaging gulp task.

@alexdima alexdima added this to the Backlog milestone Jan 9, 2018
@alexdima alexdima self-assigned this Jan 9, 2018
@alexdima alexdima mentioned this pull request Jan 10, 2018
Closed
@jens1o
Copy link
Contributor

jens1o commented Jan 10, 2018

I think this is important, because the installation will be a lot faster, even though the improvement by itself is tiny.

@kieferrm kieferrm mentioned this pull request Jan 16, 2018
Closed
55 tasks
@alexdima alexdima changed the title [WIP] Use ASAR Use ASAR Jan 29, 2018
@alexdima alexdima modified the milestones: Backlog, January 2018 Jan 29, 2018
@alexdima alexdima merged commit f27e4b0 into master Jan 29, 2018
@alexdima alexdima deleted the alex/asar branch January 30, 2018 17:00
This was referenced Feb 19, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alexdima alexdima

Labels

None yet

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

Explore using ASAR

3 participants

@alexdima @jens1o @Copilot