KEMBAR78
Clicking 'x' should be equivalent to clicking No on survey prompts and survey should not show for interactive window by joyceerhl · Pull Request #6767 · microsoft/vscode-jupyter · GitHub
Skip to content

Clicking 'x' should be equivalent to clicking No on survey prompts and survey should not show for interactive window #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2021
Merged

Clicking 'x' should be equivalent to clicking No on survey prompts and survey should not show for interactive window #6767

merged 2 commits into from
Jul 22, 2021

Conversation

@joyceerhl
Copy link
Contributor

For #6730

@joyceerhl joyceerhl requested a review from a team as a code owner July 22, 2021 19:32
@joyceerhl joyceerhl mentioned this pull request Jul 22, 2021
Closed
15 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #6767 (7d53465) into main (a0c3dd3) will decrease coverage by 0%.
The diff coverage is 50%.

@@          Coverage Diff          @@
##            main   #6767   +/-   ##
=====================================
- Coverage     68%     68%   -1%     
=====================================
  Files        411     411           
  Lines      28581   28581           
  Branches    4271    4271           
=====================================
- Hits       19497   19488    -9     
- Misses      7420    7430   +10     
+ Partials    1664    1663    -1
Impacted Files Coverage Δ
src/client/datascience/dataScienceSurveyBanner.ts 76% <50%> (ø)
src/client/common/application/debugService.ts 46% <0%> (-7%) ⬇️
...datascience/editor-integration/codelensprovider.ts 81% <0%> (-3%) ⬇️
.../datascience/editor-integration/codeLensFactory.ts 84% <0%> (-2%) ⬇️
src/client/datascience/raw-kernel/rawSocket.ts 84% <0%> (-2%) ⬇️
...ient/datascience/editor-integration/codewatcher.ts 68% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 75% <0%> (-1%) ⬇️
...t/common/variables/environmentVariablesProvider.ts 77% <0%> (ø)
src/client/datascience/baseJupyterSession.ts 69% <0%> (+<1%) ⬆️
...t/datascience/notebook/vscodeNotebookController.ts 77% <0%> (+<1%) ⬆️
... and 1 more

@joyceerhl joyceerhl merged commit 00fa3e7 into main Jul 22, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/survey-cooldown branch July 22, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joyceerhl @codecov-commenter @rchiodo