KEMBAR78
Confusing looking at comments from older commits · Issue #89 · microsoft/vscode-pull-request-github · GitHub
Skip to content

Confusing looking at comments from older commits #89

@Tyriar

Description

@Tyriar

Some UX feedback. I was reviewing this PR xtermjs/xterm.js#1543 and this is what I did:

  1. See notification in octobox
  2. Checkout PR
  3. Click comments panel
  4. See my old comment which I thought had been actioned because of notification
  5. git pull in terminal
  6. Close the diff editor and click the comment again
  7. Close the diff editor and open SelectionRendererLayer.ts and see the change was made

Perhaps an "Outdated" label somewhere would help with this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions