Render the overview page with React #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title bar looks pretty good, actions are not wired. Co-Authored-By: Stanley Goldman <stanleygoldman@github.com>
Co-Authored-By: Stanley Goldman <stanleygoldman@github.com>
Co-Authored-By: Tilde Ann Thurium <annthurium@github.com>
Co-Authored-By: Tilde Ann Thurium <annthurium@github.com>
Co-Authored-By: Tilde Ann Thurium <annthurium@github.com>
RMacfarlane
reviewed
Apr 2, 2019
rebornix
reviewed
Apr 3, 2019
queerviolet
changed the title
added 4 commits
May 3, 2019 12:57
|
Okay, got through those changes, and finally got us saving and restoring draft comments appropriately. PTAL @RMacfarlane @StanleyGoldman |
RMacfarlane
reviewed
May 6, 2019
added 3 commits
May 6, 2019 16:08
Co-Authored-By: stanleygoldman@github.com
Co-Authored-By: stanleygoldman@github.com
Co-Authored-By: stanleygoldman@github.com
Co-Authored-By: stanleygoldman@github.com
|
Two things just noticed, don't want to forget.
|
Co-Authored-By: stanleygoldman@github.com
…omment Checking if the repository returns avatars
…ithub into qv/react
StanleyGoldman
approved these changes
May 8, 2019
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces React, which we then use to render the preview page.
The conversion is fairly straightforward, mostly maintaining the page structure and appearance while converting the plumbing to React. We now use a React context—the
PullRequestContext, defined incontext.tsx, to pass mutation functions down to components. The context object, initialized at page load time, also maintains the current state of the PR, and sends it to the root component via an event listener.Fixes #416
TODO: