KEMBAR78
Suggested Assignees by benibenj · Pull Request #3681 · microsoft/vscode-pull-request-github · GitHub
Skip to content

Suggested Assignees #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2022
Merged

Suggested Assignees #3681

merged 3 commits into from
Jul 7, 2022

Conversation

@benibenj
Copy link
Contributor

@benibenj benibenj commented Jul 4, 2022

No description provided.

@benibenj benibenj requested a review from alexr00 July 4, 2022 10:40
benibenj
benibenj commented Jul 4, 2022
View reviewed changes
@benibenj benibenj linked an issue Jul 4, 2022 that may be closed by this pull request
Owner dropdown should list me first #3627
Closed
alexr00
alexr00 requested changes Jul 4, 2022
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! Just a few small style/preference/nit change requests.

@benibenj benibenj assigned benibenj and unassigned benibenj Jul 4, 2022
@benibenj benibenj modified the milestone: June 2022 Jul 4, 2022
alexr00
alexr00 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I will branch for release tomorrow and then we can merge.

@benibenj benibenj merged commit 982e07b into main Jul 7, 2022
@benibenj benibenj deleted the benibenj/assigneeOrder branch July 7, 2022 08:48
@alexr00 alexr00 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@benibenj benibenj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Owner dropdown should list me first

3 participants

@benibenj @alexr00