KEMBAR78
Use an enum for OS Types · Issue #2238 · microsoft/vscode-python · GitHub
Skip to content

Use an enum for OS Types #2238

@DonJayamanne

Description

@DonJayamanne

Current we use boolean values to determine whether os is one of Mac, Windows or Linux.
Should consider using an Enum.
This could result in a number of changes, however I believe it is worth, and needs to be done.
Using 3 booleans doesn't work well, when all of them are mutually exclusive.

Suggestion:

export enum OS {
	Linux = 'Linux',
	Mac = 'Mac',
	Windows = 'Windows'
}

@Microsoft/pvsc-team

Metadata

Metadata

Assignees

No one assigned

    Labels

    debtCovers everything internal: CI, testing, refactoring of the codebase, etc.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions