KEMBAR78
Add startup activation by karthiknadig · Pull Request #196 · microsoft/vscode-python-environments · GitHub
Skip to content

Add startup activation #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 67 commits into from
Apr 24, 2025
Merged

Add startup activation #196

merged 67 commits into from
Apr 24, 2025

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Feb 21, 2025 •
edited
Loading

Fixes #201
Fixes #200
Fixes #227
Fixes #231

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Feb 21, 2025
@karthiknadig karthiknadig self-assigned this Feb 21, 2025
This was referenced Feb 24, 2025
Closed
Closed
Closed
@karthiknadig karthiknadig force-pushed the add-startup-activation branch from f67a1fb to 13ce1e4 Compare March 9, 2025 04:17
@karthiknadig karthiknadig force-pushed the add-startup-activation branch 3 times, most recently from ddc661c to f92d94b Compare March 21, 2025 20:18
@karthiknadig karthiknadig force-pushed the add-startup-activation branch from 949c5a4 to 2a1a618 Compare April 1, 2025 17:06
@karthiknadig karthiknadig force-pushed the add-startup-activation branch 3 times, most recently from 2df81f9 to 960ac5a Compare April 16, 2025 00:54
@karthiknadig karthiknadig force-pushed the add-startup-activation branch from daa14b2 to e68c9e3 Compare April 23, 2025 23:22
@karthiknadig karthiknadig force-pushed the add-startup-activation branch from 24f0fe0 to 24cc560 Compare April 24, 2025 05:01
@karthiknadig karthiknadig marked this pull request as ready for review April 24, 2025 15:46
@vs-code-engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 24, 2025
eleanorjboyd
eleanorjboyd reviewed Apr 24, 2025
View reviewed changes
eleanorjboyd
eleanorjboyd reviewed Apr 24, 2025
View reviewed changes
src/features/terminal/terminalManager.ts
await withProgress(
{
location: ProgressLocation.Window,
title: `Activating environment: ${environment.environmentPath.fsPath}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be l10?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

eleanorjboyd
eleanorjboyd reviewed Apr 24, 2025
View reviewed changes
src/features/terminal/terminalManager.ts
}

// https://github.com/microsoft/vscode-python-environments/issues/172
// const name = options.name ?? `Python: ${environment.displayName}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this was left behind?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is what we need to uncomment after the issue above is fixed.

eleanorjboyd
eleanorjboyd reviewed Apr 24, 2025
View reviewed changes
src/features/terminal/terminalManager.ts
});
}

// https://github.com/microsoft/vscode-python-environments/issues/172
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth clarifying why this issue is there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

eleanorjboyd
eleanorjboyd reviewed Apr 24, 2025
View reviewed changes
src/features/terminal/terminalManager.ts
await waitForShellIntegration(terminal);
await this.activate(terminal, environment);
},
if (actType === 'command') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth having constants for all the activation types instead of the strings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion, will add in a flow up PR.

eleanorjboyd
eleanorjboyd reviewed Apr 24, 2025
View reviewed changes
src/managers/conda/condaUtils.ts
return selected;
}

async function installPython(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to give a version to install? Or is this like quick install?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is like quick install

@karthiknadig karthiknadig merged commit ed61d79 into microsoft:main Apr 24, 2025
6 checks passed
@karthiknadig karthiknadig deleted the add-startup-activation branch April 24, 2025 16:50
This was referenced Apr 25, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@anthonykim1 anthonykim1 mentioned this pull request Jun 12, 2025
Closed
NguyenCuong1989 referenced this pull request in NguyenCuong1989/vscode-python-environments Oct 23, 2025
@karthiknadig
Add startup activation (#196)
cf322e4 
Fixes microsoft/vscode-python-environments#201
Fixes microsoft/vscode-python-environments#200
Fixes microsoft/vscode-python-environments#227
Fixes microsoft/vscode-python-environments#231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eleanorjboyd eleanorjboyd eleanorjboyd approved these changes

Assignees

@karthiknadig karthiknadig

Labels

feature-request Request for new features or functionality

Projects

None yet

Milestone

April 2025

2 participants

@karthiknadig @eleanorjboyd