KEMBAR78
Use dedicated arch `cfg` writer by kennykerr · Pull Request #3430 · microsoft/windows-rs · GitHub
Skip to content

Conversation

@kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Jan 9, 2025

On the way to fixing #3425, there are a few areas in which cfg generation is quite difficult to reason about. I'll be making a few changes here to simplify and make it more targeted so that we can get more accurate cfg generation for feature-gating.

Previously, all of the cfg attributes were calculated and written together. The trouble with this is that the arch cfg is applied to C++ types regardless while the remaining cfg attributes are applied to all types but only during package generation as it relates to feature-gating. This way each can be tailored and simplified and only calculated when actually needed.

@kennykerr kennykerr changed the title Use dedicate arch cfg writer Use dedicated arch cfg writer Jan 9, 2025
@kennykerr kennykerr merged commit c8616a4 into master Jan 9, 2025
75 checks passed
@kennykerr kennykerr deleted the write_arches branch January 9, 2025 18:38
@kennykerr kennykerr mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant