Use dedicated arch cfg writer
#3430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the way to fixing #3425, there are a few areas in which
cfggeneration is quite difficult to reason about. I'll be making a few changes here to simplify and make it more targeted so that we can get more accuratecfggeneration for feature-gating.Previously, all of the
cfgattributes were calculated and written together. The trouble with this is that the archcfgis applied to C++ types regardless while the remainingcfgattributes are applied to all types but only during package generation as it relates to feature-gating. This way each can be tailored and simplified and only calculated when actually needed.