Use unique path for cppwinrt temp file
#3455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could also defer to Win32 API |
|
That would definitely be more difficult and unsafe. 🫢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a problem consumers will face but my CI tests occasionally fail on windows-rs due to tests running in parallel as there's IO contention on the temp file. This update just ensures that each invocation gets a unique file name so there's no contention. Ideally there'd be a simpler way to produce a unique path but I can't think of any but this is simple enough.
I had previously attempted to alleviate the issue in #3289 but there was still a race as two different tests could race to create the file and then subsequently write the file. Here we just avoid the race entirely.