KEMBAR78
Support metadata with `MethodDef` constructor parent resolution by kennykerr · Pull Request #3484 · microsoft/windows-rs · GitHub
Skip to content

Conversation

kennykerr
Copy link
Collaborator

Some, typically unmerged, metadata may present MethodDef constructors for attributes type resolution. This is unusual and thus hard to test but I have manually tested this against some internal metadata to confirm that it covers this edge case in ECMA-335 parsing.

@kennykerr kennykerr requested a review from robmikh February 12, 2025 19:25
Copy link
Member

@robmikh robmikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@kennykerr kennykerr merged commit 91cfd28 into master Feb 12, 2025
78 checks passed
@kennykerr kennykerr deleted the MemberRefParent branch February 12, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants