Remove IUnknownImpl::from_inner_ref as no longer needed
#3513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaoliello
approved these changes
Feb 24, 2025
kennykerr
changed the title
IUnknownImpl::from_inner_ref as it is no longer needed
kennykerr
changed the title
IUnknownImpl::from_inner_ref as it is no longer neededIUnknownImpl::from_inner_ref as no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up part of #3055, which improved COM object support.
The
IUnknownImpl::from_inner_refmethod predates the newComObjectAPI. It allows unsafe code to cast from&Tto&T_Impl. This is a very dangerous operation because it "widens" the pointer; it requires that&Tpoint to aTthat is embedded within aT_Impl.This was necessary for some situations before the new
ComObjectAPI, but is is completely unnecessary now. The newComObjectAPI provides safe ways to do the same thing. Also, this cast is unnecessary because all COM interface trait implementations are done onT_Impltypes, not onT, so this method is unnecessary.