Derive Default for more structs
#3519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
changed the title
Default where possibleDefault for more structs
dpaoliello
approved these changes
Feb 26, 2025
Comment on lines
+232
to
+237
| && self.def.fields().all(|field| { | ||
| !matches!( | ||
| field.ty(Some(self)), | ||
| Type::ArrayFixed(..) | Type::PtrConst(..) | Type::PtrMut(..) | ||
| ) | ||
| }) |
There was a problem hiding this comment.
Not sure if this is easier to read?
Suggested change
| && self.def.fields().all(|field| { | |
| !matches!( | |
| field.ty(Some(self)), | |
| Type::ArrayFixed(..) | Type::PtrConst(..) | Type::PtrMut(..) | |
| ) | |
| }) | |
| && !self.def.fields().any(|field| { | |
| matches!( | |
| field.ty(Some(self)), | |
| Type::ArrayFixed(..) | Type::PtrConst(..) | Type::PtrMut(..) | |
| ) | |
| }) |
There was a problem hiding this comment.
Not sure either. 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where
Defaultcannot be derived for certain Windows types, but there are many more where it can and doing so improves readability and reduces code generation. This further builds on the likes of #2760, #3015, #3041, #3097, #3270 by derivingDefaultfor structs that don't use the--sysoption, although I have had a request to extend it to--syscode generation as well so I'll probably do that in a follow-up PR.Notably, Rust won't allow
Defaultto be derived for structs with explicit layout or structs with pointer or array fields. These continue to be generated bywindows-bindgenas before.