Remap common numeric types #3524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
changed the title
robmikh
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
windows-numericscrate provides graphics-oriented math types likeVector2andMatrix3x2but there are a number of older DirectX types that predate Windows numerics and can benefit from a common optimized implementation with suitable overloads and helpers.The followings numeric types are currently remapped:
D2D_MATRIX_3X2_F->Matrix3x2D3DMATRIX->Matrix4x4The following are added in this update:
D2D_POINT_2F->Vector2D2D_VECTOR_2F->Vector2D2D_VECTOR_4F->Vector4I also removed some of the
TypeNameconstants and just included their literal names directly in the remapping function as that's the only place where these types are named and this makes it a bit clearer as to what's actually being remapped.