KEMBAR78
Add `scale` and `skew` functions to `Matrix3x2` by robmikh · Pull Request #3527 · microsoft/windows-rs · GitHub
Skip to content

Add scale and skew functions to Matrix3x2 #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2025
Merged

Add scale and skew functions to Matrix3x2 #3527

merged 6 commits into from
Mar 4, 2025

Conversation

@robmikh
Copy link
Member

@robmikh robmikh commented Mar 3, 2025

This change copies over the Matrix3x2F::Scale and Matrix3x2F::Skew helpers from d2d1helper.h. Additionally, the existing rotation helper was changed to align with the pattern created with scale and scale_around, utilizing Vector2 for the center.

Finally, tests and samples were updated for these changes. A test was also added to make sure skew_around properly linked to D2D1MakeSkewMatrix.

Fixes: #2939

@robmikh robmikh requested a review from kennykerr March 3, 2025 22:29
kennykerr
kennykerr approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

We should get a dedicated test crate up for numerics under tests/libs rather than this random little test under tests/misc but I can clean that up separately.

@kennykerr kennykerr merged commit cd002f5 into microsoft:master Mar 4, 2025
34 checks passed
@kennykerr kennykerr mentioned this pull request Mar 4, 2025
Merged
@robmikh robmikh deleted the romikh/scaleskew branch March 4, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scale and skew functions of windows::Foundation::Numerics::Matrix3x2

2 participants

@robmikh @kennykerr