Apply clippy workflow to all but tests #3675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After #3677 is merged, adjust fix-environment to below and you should be good to go. - name: Fix environment
uses: ./.github/actions/fix-environment
with:
target: x86_64-pc-windows-msvc |
|
Thanks for the build help @riverar 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the clippy workflow only validates libraries and tools. This means that a lot of samples and test crates go unchecked. Although all crates are tested, clippy still points out some more pedantic but often valuable suggestions. Clippy cannot be run on tests at this time as there are too many false positives but I think it should be doable to validate everything else.