-
Notifications
You must be signed in to change notification settings - Fork 585
Turn on Clippy testing for all crates and tests #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Confirmed there's the failure: https://github.com/microsoft/windows-rs/actions/runs/16656986097/job/47144369160?pr=3692 |
|
Closing for now. |
|
Reopening now that rust-lang/rust#137018 (comment) is fixed and I can use |
|
So even though it appears that this lint has now been fixed in nightly, it does not work in stable, which is understandable if the fix has not made it into the stable builds yet. The error message is however a little odd: Previously, the nightly toolchain stated that it was an unknown lint, but the stable toolchain says it has been removed. 🤷 fyi @RalfJung Anyway, I think I may just remove this test outright until and unless a supportable alternative is found. |
|
rust-lang/rust#137018 hasn't yet propagated to stable, so naturally the lint doesn't work on stable. It'll be in the release coming out this week. |
|
The message about unknown/removed lints is just a lint, so it's easy to support this across releases: just allow |
|
Sure, I understand. I think I'm mostly just observing that it sounds a little confusing that a lint that does not exist has been removed or renamed. Or maybe I don't understand. 🙃 |
|
Yeah that's fair. There used to be a lint of that name which got removed and then we re-enabled it for this 2nd round of ABI deprecations. That's why old rustc say "removed". And then separately there was a bug you noticed where even nightly rustc called this an "unknown" lint. |
Following #3691, this turns on all of the remaining Clippy test coverage.