KEMBAR78
Turn on Clippy testing for all crates and tests by kennykerr · Pull Request #3692 · microsoft/windows-rs · GitHub
Skip to content

Conversation

@kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Jul 31, 2025

Following #3691, this turns on all of the remaining Clippy test coverage.

@kennykerr kennykerr changed the title Turn on Clipping testing of all cates and tests Turn on Clippy testing of all cates and tests Jul 31, 2025
@kennykerr kennykerr changed the title Turn on Clippy testing of all cates and tests Turn on Clippy testing of all crates and tests Jul 31, 2025
@kennykerr
Copy link
Collaborator Author

@kennykerr
Copy link
Collaborator Author

Closing for now.

@kennykerr kennykerr closed this Jul 31, 2025
@kennykerr kennykerr reopened this Aug 4, 2025
@kennykerr
Copy link
Collaborator Author

Reopening now that rust-lang/rust#137018 (comment) is fixed and I can use allow(unsupported_calling_conventions) as a workaround.

@kennykerr
Copy link
Collaborator Author

So even though it appears that this lint has now been fixed in nightly, it does not work in stable, which is understandable if the fix has not made it into the stable builds yet. The error message is however a little odd:

error: lint `unsupported_calling_conventions` has been removed: converted into hard error
 --> crates\tests\misc\debugger_visualizer\tests\test.rs:3:10
  |
3 | #![allow(unsupported_calling_conventions)]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D renamed-and-removed-lints` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(renamed_and_removed_lints)]`

Previously, the nightly toolchain stated that it was an unknown lint, but the stable toolchain says it has been removed. 🤷

fyi @RalfJung

Anyway, I think I may just remove this test outright until and unless a supportable alternative is found.

@kennykerr kennykerr changed the title Turn on Clippy testing of all crates and tests Turn on Clippy testing for all crates and tests Aug 4, 2025
@kennykerr kennykerr merged commit f25dbd0 into master Aug 4, 2025
29 checks passed
@kennykerr kennykerr deleted the clippy-tests-all branch August 4, 2025 19:57
@RalfJung
Copy link

RalfJung commented Aug 5, 2025

rust-lang/rust#137018 hasn't yet propagated to stable, so naturally the lint doesn't work on stable. It'll be in the release coming out this week.

@RalfJung
Copy link

RalfJung commented Aug 5, 2025

The message about unknown/removed lints is just a lint, so it's easy to support this across releases: just allow renamed_and_removed_lints. The error even tells you that much. You just can't expect lints to behave the same in future rustc versions, that has always been the case. -D warnings is not a configuration that is stable under upgrades or downgrades.

@kennykerr
Copy link
Collaborator Author

Sure, I understand. I think I'm mostly just observing that it sounds a little confusing that a lint that does not exist has been removed or renamed. Or maybe I don't understand. 🙃

@RalfJung
Copy link

RalfJung commented Aug 6, 2025

Yeah that's fair. There used to be a lint of that name which got removed and then we re-enabled it for this 2nd round of ABI deprecations. That's why old rustc say "removed".

And then separately there was a bug you noticed where even nightly rustc called this an "unknown" lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants