Prefer expect to allow for Rust and Clippy lints
#3716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs aren't clean on what version of Rust stabilized Looks like it is 1.81 |
kennykerr
commented
Aug 13, 2025
|
|
||
| module = LoadLibraryExA( | ||
| b"ntdll.dll\0".as_ptr(), | ||
| c"ntdll.dll".as_ptr() as _, |
There was a problem hiding this comment.
This is a false positive as Clippy insists I use c"..." but that fails to compile since the result is a signed pointer whereas LoadLibraryExA expects an unsigned pointer...
I also don't see how this is better 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benefit of
expectis that it warns if the lint is not actually triggered and thus helps to identify outdated or misapplied lints.I continue to use
allowfor macros and generated bindings.Unfortunately, the
expectattribute is new to Rust 1.81 so I have updated the MSRV for most crates as they are due for breaking change updates with the exception ofwindows-versionwhich I will leave as is to avoid bumping the MSRV.