Workaround for integer_to_ptr_transmutes warning
#3731
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
reviewed
Sep 8, 2025
| unsafe { transmute(value << 1) } | ||
| #[allow(unknown_lints, integer_to_ptr_transmutes)] | ||
| unsafe { | ||
| transmute(value << 1) |
There was a problem hiding this comment.
As the documentation of with_exposed_provenance_mut says, it's fully equivalent to an as cast, which I highly recommend using in order to avoid the UB here.
Suggested change
| transmute(value << 1) | |
| &mut *((value << 1) as *const Self) |
There was a problem hiding this comment.
Thanks for the reminder! #3749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/microsoft/windows-rs/actions/runs/17277596764/job/49038221132?pr=3730
This new warning seems a little painful.
with_exposed_provenance_mutbut that requires a higher MSRV.integer_to_ptr_transmutesbut that is an unknown lint to the current MSRV.So I have to allow both
unknown_lintsandinteger_to_ptr_transmutes.That does not seem ideal. 🤔