-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Formatting changes for localized content #5170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
These changes will get overwritten any time there is a new localization patch from the translations team. These changes need to be made to the localization team's internal process I believe |
I forwarded it to the localization team (Bug 56032525 for MS internal tracking). These choices seem stylistic to me (a non-localization expert without any experience with any of the languages involved). Given that, the localization team may not accept them as they may have internal guidelines governing these choices. |
| </data> | ||
| <data name="FontFaces" xml:space="preserve"> | ||
| <value>脸</value> | ||
| <value>Faces</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a mistake (and the one below and one in the zh-TW file). I can't imagine that using English here is correct.
Using bing translation, the current translation might be literally "face", like the part of a human being containing the eyes, nose and mouth. It suggests that 字体, 字样, or 字面 might be better fits for "typeface". @yao-msft might be able to weigh in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be translated as "字体样式" (or "字样"), but I don't have the context to know where they appear, and there's another Face in the file (line 3157), so I'm using the original English.
In any case, "脸" is definitely an incorrect translation.
In the zh-TW translation, it is translated as "表情" in one place (line 3150), but I think this is also incorrect based on the <comment>.
Change pushed.
Edit:
It suggests that 字体, 字样, or 字面 might be better fits for "typeface".
zh-CN: 家庭 -> 字体集 Face(s), 脸 -> 字体样式 尽可能禁止 -> 尽可能不 zh-TW: 家庭 -> 字體集 / 字型集 脸, 表情, Face(s) -> 字體樣式 / 字型樣式
Yes, but if those comments are programmatically consumed they didn't complain at us. It would need to be fixed in: /src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw |

Harmonization of
:in zh-CN and zh-TW localization:→::→:Completion of missing left and right spaces
For example:
...将使用Windows 程序包管理器设置中指定的...→...将使用 Windows 程序包管理器设置中指定的...See comments and commit messages below for other changes.
}#5192Microsoft Reviewers: Open in CodeFlow