Dscv3 command base #5280
Dscv3 command base #5280
Conversation
| <value>Test the resource state</value> | ||
| </data> | ||
| <data name="DscResourceFunctionDescriptionDelete" xml:space="preserve"> | ||
| <value>Delete resource state</value> |
There was a problem hiding this comment.
nit: consistency wise, some of the strings use "the" resource and others without "the"
… verbose config logging is enabled
|
Following up from #5252 (comment) We now have the stable release of DSCv3 merged into winget-pkgs as winget-cli/azure-pipelines.yml Lines 381 to 384 in a3cea27 |
|
I will make a separate change for that, once we get the MSIX in the release artifacts: |
|
@SteveL-MSFT are you planning on adding the MSIX version of DSC to the release artifacts? |
| FoundDscExecutablePath, | ||
| // Whether to request detailed traces from the processor. | ||
| // Read / Write | ||
| DiagnosticTraceLevel, |
There was a problem hiding this comment.
nit: the name "*TraceLevel" makes me think it's taking a trace level setting like warning, verbose while after reading the code, it's more like "DiagnosticTraceEnabled"
There was a problem hiding this comment.
I will do that first thing in my next change so I don't need to wait for another build cycle.
4 participants
Change
Adds infrastructure for writing DSC v3 resource commands.
Adds a new hidden command
dscv3to put the resources under.Adds a file content resource (
DscTestFileResource) that is only available when tests hooks are enabled.The resource infrastructure generates the resource manifest based on the defined functions and modifiers given to the base via
winget dscv3 <resource> --manifest. It directs theDscFunctionsit is given to the appropriate virtual method (--getmaps toResourceFunctionGet).Resources can define properties using the helper macro
WINGET_DSC_DEFINE_COMPOSABLE_PROPERTYand create an object to represent their properties withDscComposableObject. This makes extracting and writing properties to JSON easy, as well as generating a schema.Validation
Updated E2E tests to use this test resource rather than the built-in registry resource from DSC v3.
Microsoft Reviewers: Open in CodeFlow