-
Notifications
You must be signed in to change notification settings - Fork 1.6k
DSC v3 adapter support #5302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DSC v3 adapter support #5302
+229
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gijsreyn
reviewed
Mar 21, 2025
@@ -0,0 +1,10 @@ | |||
$schema: https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/08/config/document.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the DSC v3.0 GA, shouldn't this schema be changed to the bundled one and aka.ms?
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yao-msft
approved these changes
Apr 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
If we don't find a resource in DSC v3 at the top level, look in all of the adapters for it.
dsc.exe
does this automatically when using the resource, so we only need to do it when finding the resource details.Also improves the diagnostics handling and fixes an issue with the type of
implementedAs
.Validation
Adds an E2E test that uses the test v2 resource through the v3 processor.
Microsoft Reviewers: Open in CodeFlow