KEMBAR78
DSC v3 adapter support by JohnMcPMS · Pull Request #5302 · microsoft/winget-cli · GitHub
Skip to content

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Mar 17, 2025

Change

If we don't find a resource in DSC v3 at the top level, look in all of the adapters for it. dsc.exe does this automatically when using the resource, so we only need to do it when finding the resource details.

Also improves the diagnostics handling and fixes an issue with the type of implementedAs.

Validation

Adds an E2E test that uses the test v2 resource through the v3 processor.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner March 17, 2025 17:17
@@ -0,0 +1,10 @@
$schema: https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/08/config/document.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the DSC v3.0 GA, shouldn't this schema be changed to the bundled one and aka.ms?

@JohnMcPMS
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit 39b8b5a into microsoft:master Apr 14, 2025
9 checks passed
@JohnMcPMS JohnMcPMS deleted the dscv3-adapters branch April 14, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants