KEMBAR78
Add securityContext to configuration file by mdanish-kh · Pull Request #5309 · microsoft/winget-cli · GitHub
Skip to content

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Mar 19, 2025

Setting developer mode, installing Visual Studio 2022 & fetching and installing VS components all require elevation. Added securityContext: elevated for these resources. Removed allowPrerelease: true for Microsoft.WinGet.DSC/WinGetPackage as it's GA now. Also fixed a bad link in the docs


Microsoft Reviewers: Open in CodeFlow

@mdanish-kh mdanish-kh requested a review from a team as a code owner March 19, 2025 01:26
@denelon
Copy link
Collaborator

denelon commented Mar 19, 2025

I thought the Visual Studio install didn't need elevation, but I haven't installed it "fresh" on a box in a while.

@denelon denelon merged commit 6ec90f2 into microsoft:master Mar 19, 2025
3 checks passed
@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Mar 19, 2025

I thought the Visual Studio install didn't need elevation, but I haven't installed it "fresh" on a box in a while.

It does on a completely fresh install, one where the "Visual studio Installer" isn't present yet. See the GIF -

sliding5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants