KEMBAR78
Fixes for pipeline stability by JohnMcPMS · Pull Request #5359 · microsoft/winget-cli · GitHub
Skip to content

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Apr 7, 2025

Issue

Due to an issue with dsc.exe creating child processes (which after much investigation appears to be a race that only occurs on older OS versions), we get arbitrary failures.

We also occasionally get spurious failures of configuration tests.

Change

Move to windows-2025 to avoid the process creation failures from dsc.exe.
Move to Windows 11 SDK 26100 as 22000 is not installed by default on windows-2025.
Flush output at the end of a configuration unit info dump.
Add missing interface to manifest (@yao-msft was right).
Use pwsh task at least once to ensure that it is present.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner April 7, 2025 21:04
florelis
florelis previously approved these changes Apr 7, 2025
"Microsoft.VisualStudio.Component.VC.TestAdapterForGoogleTest",
"Microsoft.VisualStudio.Component.VC.ASAN",
"Microsoft.VisualStudio.Component.Vcpkg",
"Microsoft.VisualStudio.Component.Windows10SDK.19041",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep 19041?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, I don't see anything using it in this solution. I can remove it in another PR to prevent the need to rebuild this one.

WindowsPackageManager\WindowsPackageManager.dll
UndockedRegFreeWinRT\winrtact.dll
TargetFolder: $(buildOutDirAnyCpu)\PowerShell\Microsoft.WinGet.Client\net8.0-windows10.0.22000.0\SharedDependencies\$(BuildPlatform)
TargetFolder: $(buildOutDirAnyCpu)\PowerShell\Microsoft.WinGet.Client\net8.0-windows10.0.26100.0\SharedDependencies\$(BuildPlatform)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be fun to update in the internal pipeline...

Copy link
Member Author

@JohnMcPMS JohnMcPMS Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[fingers in ears] la la la la, I can't hear you

@JohnMcPMS JohnMcPMS merged commit 3267d50 into microsoft:master Apr 11, 2025
9 checks passed
@JohnMcPMS JohnMcPMS deleted the pipeline-fix branch April 11, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants