Better DefaultInstallVersion #5389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
commented
Apr 16, 2025
| return m_defaultInstallVersion; | ||
| InitializeLatestApplicableVersion(); | ||
|
|
||
| if (m_latestApplicableVersion) |
There was a problem hiding this comment.
If people absolutely do not want applicability check for DefaultInstallVersion, I can remove this if statement. But I feel having applicability check will lower chances of upgrade failures.
JohnMcPMS
reviewed
Apr 16, 2025
| } | ||
| else if (AvailableVersions().Size() > 0) | ||
| { | ||
| return GetPackageVersionInfo(AvailableVersions().GetAt(0)); |
There was a problem hiding this comment.
I would rather that this decision be made in the call_once, but I also refactored this entire function elsewhere in my upcoming PR. So I will move that when I handle the merge conflict that this creates...
JohnMcPMS
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultInstallVersion being null causes larger than expected issues. The change proposes to return latest applicable version if exists, to minimize duplicate installs/ upgrade failures. If no latest applicable version, return latest available version if exists.
Microsoft Reviewers: Open in CodeFlow