Place DSCv3 resource manifests in the package #5433
Merged
+159
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… project pick up resource manifests
yao-msft
previously approved these changes
May 5, 2025
yao-msft
reviewed
May 5, 2025
| { | ||
| Argument GetOutputFileArgument() | ||
| { | ||
| return { Execution::Args::Type::OutputFile, Resource::String::OutputFileArgumentDescription, ArgumentType::Standard }; |
There was a problem hiding this comment.
nit: Do we consider differentiating output file vs output directory?
There was a problem hiding this comment.
Changed the description, left the arg type the same.
yao-msft
previously approved these changes
May 5, 2025
yao-msft
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Adds a method to write all manifests to a directory with one command. Uses that to write all DSCv3 resource manifests and add them to the package files.
Also changes the "module" name for the dev package to add ".Dev" and updated export to use the shared definition of the module name. This involved a minor refactor to remove static globals and unnecessary string constructions.
Finally, moves to using the DSC v3
UserSettingsFileresource rather than the v2 version.Validation
The package builds successfully as desired locally.
Microsoft Reviewers: Open in CodeFlow