Install dsc v3 package if not found when processing dsc v3 configuration file #5437
+47
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
May 7, 2025
| winrt::hstring foundExecutablePath = factoryMap.Lookup(ConfigurationRemoting::ToHString(ConfigurationRemoting::PropertyName::FoundDscExecutablePath)); | ||
| if (foundExecutablePath.empty()) | ||
| { | ||
| AICLI_LOG(Config, Info, << "dsc.exe not found and not provided. Installing dsc package from store."); |
There was a problem hiding this comment.
Needs a user presentable message sent out as well.
Comment on lines
219
to
220
| AICLI_LOG(Config, Error, << "Could not find dsc.exe, it must be provided by the user."); | ||
| THROW_WIN32(ERROR_FILE_NOT_FOUND); |
There was a problem hiding this comment.
User message and use TERMINATE_CONTEXT instead of throwing directly.
There was a problem hiding this comment.
The MSStoreInstall workflow task prints installation failed message with error code to the screen. I guess we don't need a duplicate install failed message here.
There was a problem hiding this comment.
I'm more concerned about the mitigation message than the "install failed". Inform the user that they can provide the argument for the location of dsc.
JohnMcPMS
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated by removing the "install dsc v3" step in pipeline and e2e tests work.
Microsoft Reviewers: Open in CodeFlow