Undefined-behaviour fix: safely call std::isspace in CompletionData #5564
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What was fixed [CompletionData.cpp](cci:7://file:///c:/Users/T2430514/Downloads/winget-cli/src/AppInstallerCLICore/CompletionData.cpp:0:0-0:0) passed a potentially negative `char` to `std::isspace`, invoking undefined behaviour on non-ASCII input (signed `char` platforms). This occasionally caused crashes or incorrect cursor repositioning when autocompleting commands containing UTF-8 characters. ### How it was fixed The character is now explicitly cast to `unsigned char` before the `std::isspace` check: ```cpp !std::isspace(static_cast<unsigned char>(commandLine[cursor - 1])) ``` This aligns with standard C++ guidance and makes the completion logic robust across all locales. Co-Authored-By: S. M. Mohiuddin Khan Shiam <147746955+mohiuddin-khan-shiam@users.noreply.github.com>
### What was fixed [CompletionData.cpp](cci:7://file:///c:/Users/T2430514/Downloads/winget-cli/src/AppInstallerCLICore/CompletionData.cpp:0:0-0:0) passed a potentially negative `char` to `std::isspace`, invoking undefined behaviour on non-ASCII input (signed `char` platforms). This occasionally caused crashes or incorrect cursor repositioning when autocompleting commands containing UTF-8 characters. ### How it was fixed The character is now explicitly cast to `unsigned char` before the `std::isspace` check: ```cpp !std::isspace(static_cast<unsigned char>(commandLine[cursor - 1])) ``` This aligns with standard C++ guidance and makes the completion logic robust across all locales.
|
/azp run |
florelis
approved these changes
Jul 10, 2025
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was fixed
CompletionData.cpp passed a potentially negative
chartostd::isspace, invoking undefined behaviour on non-ASCII input (signedcharplatforms). This occasionally caused crashes or incorrect cursor repositioning when autocompleting commands containing UTF-8 characters.How it was fixed
The character is now explicitly cast to
unsigned charbefore thestd::isspacecheck:This aligns with standard C++ guidance and makes the completion logic robust across all locales.
Microsoft Reviewers: Open in CodeFlow