KEMBAR78
Handle Byte Order Mark during validation by Trenly · Pull Request #5585 · microsoft/winget-cli · GitHub
Skip to content

Handle Byte Order Mark during validation #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 26, 2025
Merged

Handle Byte Order Mark during validation #5585

merged 4 commits into from
Jul 26, 2025
+21 −7

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jul 10, 2025 •
edited by microsoft-github-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

yao-msft
yao-msft reviewed Jul 16, 2025
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Trenly Trenly requested a review from yao-msft July 24, 2025 16:26
yao-msft
yao-msft previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we enforce utf8 in our winget-pkgs manifests? If not, I feel the real fix need to include ExtractDocumentHeader side fixes. (I'm not asking for it now as it's a winget-pkgs only thing).

@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Jul 26, 2025

Do we enforce utf8 in our winget-pkgs manifests? If not, I feel the real fix need to include ExtractDocumentHeader side fixes. (I'm not asking for it now as it's a winget-pkgs only thing).

I believe we do enforce it at winget-pkgs, not certain about private repos

@yao-msft yao-msft merged commit b50a974 into microsoft:master Jul 26, 2025
3 checks passed
@Trenly Trenly deleted the BomFix branch July 26, 2025 02:17
@Trenly Trenly mentioned this pull request Jul 26, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

YAML with UTF-8 BOM are not handled correctly

2 participants

@Trenly @yao-msft