KEMBAR78
[Cherry-Pick] Add missing compilation flags for vcpkg ports (#5587) by florelis · Pull Request #5589 · microsoft/winget-cli · GitHub
Skip to content

Conversation

florelis
Copy link
Member

@florelis florelis commented Jul 14, 2025

#5567 didn't actually fix the crash we were seeing.

The actual cause of the crash seems to be that I missed adding some compilation flags that we had added to the .vcxproj for cpprestsdk when I moved the dependencies to vcpkg (which does not use the .vcxproj). Specifically, I didn't set a flag to compile it without async support, so the library used async but winget wasn't prepared for that.

This PR adds the missing compilation flags for all ports, taken from the project files before the migration to vcpkg. I added the flags to the triplet files (conditionally) so that it applies the same regardless of whether a port comes from the official registry or a local overlay.

I noticed that for libyaml and jsoncpp I missed the flags to prepare for fuzzing, so I added a new triplet for those.

This PR also updates the pipeline to publish the compilation logs from vcpkg for easier debugging in the future.

Microsoft Reviewers: Open in CodeFlow

microsoft#5567 didn't actually fix the crash we were seeing.

The actual cause of the crash seems to be that I missed adding some
compilation flags that we had added to the `.vcxproj` for cpprestsdk
when I moved the dependencies to vcpkg (which does not use the
`.vcxproj`). Specifically, I didn't set a flag to compile it without
async support, so the library used async but winget wasn't prepared for
that.

This PR adds the missing compilation flags for all ports, taken from the
project files before the migration to vcpkg. I added the flags to the
triplet files (conditionally) so that it applies the same regardless of
whether a port comes from the official registry or a local overlay.

I noticed that for `libyaml` and `jsoncpp` I missed the flags to prepare
for fuzzing, so I added a new triplet for those.

This PR also updates the pipeline to publish the compilation logs from
vcpkg for easier debugging in the future.
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5587)
@florelis florelis merged commit 36831fc into microsoft:release-v1.11 Jul 14, 2025
4 checks passed
@florelis florelis deleted the cherry-pick branch July 14, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants