Add RestSource and tests for Manifest v1.12 #5695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
Aug 27, 2025
src/AppInstallerRepositoryCore/Rest/Schema/1_12/Json/ManifestDeserializer_1_12.cpp
Outdated
Show resolved
Hide resolved
| const Utility::Version Version_1_7_0{ "1.7.0" }; | ||
| const Utility::Version Version_1_9_0{ "1.9.0" }; | ||
| const Utility::Version Version_1_10_0{ "1.10.0" }; | ||
| const Utility::Version Version_1_12_0{ "1.12.0" }; |
There was a problem hiding this comment.
I suppose I never realized how many unnecessary allocating statics we had laying around. <grumbles about C# devs>
JohnMcPMS
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5694
Updates the RestSource and interface to support v1.12 Manifest schema.
Tested:
(This is part of schema update for 1.12 so nothing new to add to release notes.)