Cache information responses from REST sources #5726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Sep 24, 2025
|
|
||
| bool IsValidNonEmptyStringValue(std::optional<std::wstring>& value) | ||
| { | ||
| if (Utility::IsEmptyOrWhitespace(value.value_or(L""))) |
There was a problem hiding this comment.
nit: return !Utility::IsEmptyOrWhitespace...
| { | ||
| using namespace std::string_view_literals; | ||
| constexpr std::string_view s_DefaultTempDirectory = "WinGet"sv; | ||
| constexpr std::string_view s_SettingsFile_Relative = "Settings"sv; |
There was a problem hiding this comment.
nit: The s_SecureSettings_UserRelative below uses "settings", will that potentially cause conflicts in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Store and use the
/informationresponse from REST sources per theircache-controlheader.At the base of this change is a new type of setting stream:
Encrypted. These settings are encrypted to the user and machine that the data is stored on.Based on the log file from running with and without a cached value, the time between close log lines dropped from 189 ms to 8 ms for the msstore source. This time saving should be in effect for the large majority of uses of WinGet.
Validation
Added tests across various levels of the change.
Manually verified functionality of CLI.
Microsoft Reviewers: Open in CodeFlow