KEMBAR78
Fix install source and final progress by JohnMcPMS · Pull Request #5764 · microsoft/winget-cli · GitHub
Skip to content

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Oct 1, 2025

Fixes #5715

Change

Use the correct property when filtering for the source.
Send a final progress message when successful to ensure that clients that display the progress don't get stuck with "finishing up".

Validation

Manually confirmed that both changes work.

Microsoft Reviewers: Open in CodeFlow

{
var catalogRef = catalogs[i];
if (string.IsNullOrEmpty(catalog) || catalogRef?.Info.Id == catalog)
if (string.IsNullOrEmpty(catalog) || catalogRef?.Info.Name == catalog)

This comment was marked as resolved.

This comment was marked as resolved.

@JohnMcPMS JohnMcPMS merged commit ae31791 into microsoft:master Oct 3, 2025
9 checks passed
@JohnMcPMS JohnMcPMS deleted the mcp-source branch October 3, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP server unable to install packages when the source parameter is used

2 participants