-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove experimental from Font Install, Uninstall, and source #5791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the experimental flag from Font Install, Uninstall operations and font source support, making these features generally available. The font command itself remains experimental.
- Removes experimental feature checks from font install/uninstall workflows
- Updates font source policy to no longer require experimental feature flag
- Updates documentation to reflect font features are now non-experimental
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/AppInstallerRepositoryCore/SourcePolicy.cpp | Removes experimental feature requirement for WinGet font source |
src/AppInstallerCLIE2ETests/GroupPolicy.cs | Removes experimental font feature configuration from test |
src/AppInstallerCLICore/Workflows/UninstallFlow.cpp | Removes experimental feature check from font uninstall workflow |
src/AppInstallerCLICore/Workflows/InstallFlow.cpp | Removes experimental feature check from font install workflow |
doc/ReleaseNotes.md | Updates release notes to document font features as non-experimental |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Explicit com
Forgot about the IEnumerable handling problems
This removes experimental from font install, uninstall, and source.
The font command remains experimental and is not required to install or remove fonts, which use the normal install and uninstall flow for a WinGet package.
Microsoft Reviewers: Open in CodeFlow