KEMBAR78
Fix eval duplicate logging issue by mvpatel2000 · Pull Request #2018 · mosaicml/composer · GitHub
Skip to content

Conversation

@mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Mar 1, 2023

What does this PR do?

Fix eval duplicate logging issue. Along for the ride, refactor and clean up console log testing.

image

What issue(s) does this change relate to?

fix CO-1769

Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this! Tests are much better now. Can you add a sample output in the description?

@mvpatel2000 mvpatel2000 merged commit 3d63efe into mosaicml:dev Mar 1, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/rm-end branch March 1, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants