Add cel tests for upstreamsettingspolicy #3742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
- Coverage 86.90% 86.87% -0.04%
==========================================
Files 128 128
Lines 16201 16201
Branches 62 62
==========================================
- Hits 14079 14074 -5
- Misses 1949 1954 +5
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shaun-nx
reviewed
Aug 15, 2025
shaun-nx
reviewed
Aug 15, 2025
shaun-nx
reviewed
Aug 15, 2025
sarthyparty
force-pushed
the
tests/cel-upstreamsettingspolicy
branch
from
51b7ad2 to
27429bd
Compare
salonichf5
reviewed
Aug 15, 2025
salonichf5
reviewed
Aug 15, 2025
shaun-nx
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: There were no CEL tests for UpstreamSettingsPolicy
Solution: I added it
Testing: Describe any testing that you did.
Closes #3672
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.